wellcomecollection / wellcomecollection.org

🪟 Wellcome Collection's website and services that support it
https://wellcomecollection.org
MIT License
39 stars 5 forks source link

Reference number not displaying for some works #10565

Closed pollecuttn closed 7 months ago

pollecuttn commented 8 months ago

What

Reported for Drawings of an epidural and c-section at John Radcliffe Hospital, Oxford, 4 May 1987. https://wellcomecollection.org/works/hh8dhtur

See Slack

Where

The reference does display on https://wellcomecollection.org/works/hh8dhtur but is missing from lower level works:

Cf e.g. these where the reference is on both the higher and lower level works:

I'm don't know if this has always been like this.

TODO Dev to investigate:

rcantin-w commented 7 months ago

The header reference number comes from work.referenceNumber whereas the one in the body comes from work.notes, which is a list that contains:

 {
    contents: [ 'Wellcome Collection 3329263i' ],
    noteType: { id: 'reference', label: 'Reference', type: 'NoteType' },
    type: 'Note'
  }

I'm trying to grasp a bit better where these come from but it's API side, so will get back with a clearer answer after I've discussed it with someone that has a better understanding of the Works API and how items relate to each other.

rcantin-w commented 7 months ago

Root of the issue was found to be a regex in the Sierra transformer (see Slack thread). Seems to be a quick enough fix but let's bring it to the next planning to be prioritised then? I'll move this card to the Collections backlog.

paul-butcher commented 7 months ago

As @rcantin-w and I had essentially done the work when we were trying to find out which side of the system this problem is on, I have turned it into a PR