wellcomecollection / wellcomecollection.org

🪟 Wellcome Collection's website and services that support it
https://wellcomecollection.org
MIT License
39 stars 5 forks source link

Requesting e2e tests #10591

Open kenoir opened 10 months ago

kenoir commented 10 months ago

What?

We should have some end-to-end tests around item requesting. We'd like to do some discovery work around mocking items-api interactions in order to gauge the difficulty of creating these tests.

Why?

We are missing these at present and could miss breaking functionality associated with requesting when we deploy wellcomecollection.org

Background

We've had a framework for these tests in the past but recently removed it as they weren't exercising the expected functionality: https://github.com/wellcomecollection/wellcomecollection.org/pull/10578

We're looking at an approach where we mock items-api interactions in playwright via various mechanisms:

Meeting document, discussing options.

We think mocking the items-api and testing up to viewing request state is a good compromise given the difficulty of other approaches.

Done when

LFBaily commented 9 months ago

Moving a few of these which I think are on the wrong board.