wellcomecollection / wellcomecollection.org

🪟 Wellcome Collection's website and services that support it
https://wellcomecollection.org
MIT License
37 stars 5 forks source link

Move Prismic Linting over to Github actions, occur once a day only #10843

Closed rcantin-w closed 2 weeks ago

rcantin-w commented 2 months ago

Prismic linting is a Buildkite task that runs on every branch's every commit that is pushed to Github. It's also triggered every 20 minutes of office hours. I believe that it is not necessary. The linting report get consulted at most once a day, so putting this on a once a day schedule instead would be a better use of resources.

The script currently scours the Prismic data for these checks;

I don't think any of this requires the script to be run that often.

Had a chat with @kenoir, he's expressed interest in taking it away from Buildkite into a Github action. This would also mean having to set up appropriate AWS access for Github actions in the wc.org repo, which would probably be useful in the future anyway. That has been done before in other repos so there is a reference available.

rcantin-w commented 2 weeks ago

Depends on https://github.com/wellcomecollection/platform/issues/5752 being done

rcantin-w commented 2 weeks ago

Changes are deployed so we'll see when we get back if it ran at 8am.

rcantin-w commented 2 weeks ago

The action worked the last few days 👍 people were told about the change in Slack and we've tweaked the schedule to be earlier to account for BST/GMT (will now run at 4UTC)