Closed rcantin-w closed 3 months ago
For reference, I tested some of these upgrade to Node 18 in this test PR (which I'll now close).
I've just noticed this as a TODO in our github workflow files:
# TODO: Remove this line when we can safely upgrade all our packages
# to versions that support Node 16.
# See https://github.com/wellcomecollection/wellcomecollection.org/pull/9324
- uses: actions/setup-node@v4
with:
node-version: 16
Coming from this PR
So I'll add it as a thing to do in this ticket's description.
David published this NodeJS upgrade process in Gitbook: https://app.gitbook.com/o/-LumfFcEMKx4gYXKAZTQ/s/DPDDj27NI2F2kPukWrC1/language-tool-specific-notes/nodejs-updates
A good test will be for the next person that upgrades to use it and see if anything is missing/not necessary/anything.
@pollecuttn @LaurenFBaily, as reviewing our Node versions should be a recurring task (we haven't decided have we? Possibly twice a year?), an idea could be to have a link to this document in future Node upgrade tickets/quarterly plannings.
Edit the root .nvmrc and remove unnecessary ones.
Will get done once https://github.com/wellcomecollection/wellcomecollection.org/issues/10929 is deployed.
Closing as all done and deployed to prod
We need to look at upgrading our Node versions as most of our project is running on Node 16 and that is deprecated. (More info about other versions in their repo)
Here's what we're currently on for all the sub-repos, linked with their upgrade ticket:
So some are on 18 already, but as 20 is the current LTS we're thinking we could trial that first. 18 reaches EOL at the end of April 2025, so would be nice to not have to think about it for a while (20 gives us an extra year).
It could (and should) be done in multiple steps, as many as there are sub-repos above, except for the first one which should happen at the same time. There is also the *special case of
cache/edge_lambdas
, which is partly running on Node 12, which means we have to think about how to move it over more carefully (there is no staging environment, therefore no way to test it).This ticket could serve as an epic equivalent for this piece of work.
.nvmrc
and remove unnecessary ones.