Closed rcantin-w closed 2 weeks ago
Size Change: +354 B (+0.04%)
Total Size: 969 kB
Filename | Size | Change | |
---|---|---|---|
content/webapp/.next/static/chunks/1002-c9f63056c57ba987.js |
0 B | -4.29 kB (removed) | đ |
content/webapp/.next/static/chunks/3021.911fda038d679160.js |
0 B | -2.38 kB (removed) | đ |
content/webapp/.next/static/chunks/8060.895d4f706a719810.js |
0 B | -2.45 kB (removed) | đ |
content/webapp/.next/static/chunks/8651-406a4d8be8263f2e.js |
0 B | -3.18 kB (removed) | đ |
content/webapp/.next/static/chunks/pages/_app-218f91b12f017c7a.js |
0 B | -107 kB (removed) | đ |
content/webapp/.next/static/chunks/pages/guides/exhibitions-9267bfa97e61640c.js |
0 B | -4.29 kB (removed) | đ |
content/webapp/.next/static/chunks/webpack-bbeb75ab1afafaea.js |
0 B | -2.28 kB (removed) | đ |
identity/webapp/.next/static/chunks/pages/_app-0101be56ac57db6d.js |
0 B | -100 kB (removed) | đ |
identity/webapp/.next/static/chunks/pages/index-5c1854081d923910.js |
0 B | -12 kB (removed) | đ |
content/webapp/.next/static/chunks/1002-dec5b2e7040eaf27.js |
4.34 kB | +4.34 kB (new file) | đ |
content/webapp/.next/static/chunks/3021.869e93edba081296.js |
2.42 kB | +2.42 kB (new file) | đ |
content/webapp/.next/static/chunks/8060.3eaa1a34ace0f486.js |
2.47 kB | +2.47 kB (new file) | đ |
content/webapp/.next/static/chunks/8651-ea72b75830fa5140.js |
3.22 kB | +3.22 kB (new file) | đ |
content/webapp/.next/static/chunks/pages/_app-549002b80a6917ff.js |
107 kB | +107 kB (new file) | đ |
content/webapp/.next/static/chunks/pages/guides/exhibitions-4229fc4dcae50aa6.js |
4.31 kB | +4.31 kB (new file) | đ |
content/webapp/.next/static/chunks/webpack-102596ca9766fcc5.js |
2.28 kB | +2.28 kB (new file) | đ |
identity/webapp/.next/static/chunks/pages/_app-7231589420be2957.js |
100 kB | +100 kB (new file) | đ |
identity/webapp/.next/static/chunks/pages/index-bc73c6d82c3f3d85.js |
12.1 kB | +12.1 kB (new file) | đ |
A nice idea! I think I'll leave the logic where it is but will create a const for the ID of what should be found (so like const ACTIVE_COOKIE_BANNER = "ccc-overlay";
within the civic-uk files and import it where needed.
Who is this for?
10915
What is it doing for them?
On live environments it seems that the modal/cookie banner need more time to detect interactions with the other, and so we need to be able to control
hasAcknowledgedCookieBanner
from the Modal. The modal checks if the overlay is active (which means either the banner or the popup is there) and that turns off the focus lock.I've aimed to test as much as possible on the e2e environment and it seems to work nicely, but as we had to revert the last "fix" (which was wonky I admit), if this can be tested locally as well I reckon all the better!
I'll squash and merge for this as I made a lot of noisy useless commits for the sake of debugging.