github-actions[bot]
commented
3 days ago Size Change: +24 B (0%)
Total Size: 978 kB
| Filename | Size | Change | |
|---|---|---|---|
content/webapp/.next/static/chunks/4621-6389983752d98bfa.js |
0 B | -5.11 kB (removed) | 🏆 |
content/webapp/.next/static/chunks/4962-68bb7d1d02721b2a.js |
0 B | -12.3 kB (removed) | 🏆 |
identity/webapp/.next/static/chunks/pages/index-bc73c6d82c3f3d85.js |
0 B | -12.1 kB (removed) | 🏆 |
identity/webapp/.next/static/chunks/webpack-713796e2734212eb.js |
0 B | -1.82 kB (removed) | 🏆 |
content/webapp/.next/static/chunks/4621-d854f758923784b3.js |
5.11 kB | +5.11 kB (new file) | 🆕 |
content/webapp/.next/static/chunks/4962-a0a4531c5d6065ae.js |
12.3 kB | +12.3 kB (new file) | 🆕 |
identity/webapp/.next/static/chunks/pages/index-744b70e8931f1e55.js |
12.1 kB | +12.1 kB (new file) | 🆕 |
identity/webapp/.next/static/chunks/webpack-2e2c0b3078f78fb0.js |
1.82 kB | +1.82 kB (new file) | 🆕 |
Reverts wellcomecollection/wellcomecollection.org#10977 as I'd merged it too quickly. I'll paste the original PR description below
Who is this for?
Maintenance and best practices
10844
What is it doing for them?
Enforces a Typescript check on all PRs, which I'll later suggest we make a required pass for something to get merged in. We had situations like library changes, or changes to Prismic types and model that meant lesser used files fell into a legacy trap; mock content for tests, for example, was using older shaped data. The goal for this is to ensure these are updated as we go, even if it's not part of the PR we do - if we do this consistently, the change should never be big enough to warrant making that test optional and will ensure we keep our files across the Workspace up-to-date.
This PR adds the Github action, as well as fixes all the errors it found. I tried to this in many commits to ease the review process, so have a look through there.
The
tsccommand line goes across all the repos that are marked as part of the workspace (socardigan,common,content,identity,prismic-modelandtoggles). I wanted to ensure they all had the same rules, so a lot of theirtsconfigfiles have been updated to reflect that, but it's a work in progress. My next step will be to 1) have them use the same config file so any rule changes affects the whole workspace and 2) review those rules as I don't think they all might still be needed.identity, for example, has some very different settings. We could then extend that set of rules to our other TS projects.The tests currently run one after the other and run in less than 3minutes if all is well. The latest version of Yarn has a
paralleloption for workspaces commands I would've like to use but we're on1.22.22. One for another time!Please let me know if you have any questions or suggestions for this piece.