Closed rcantin-w closed 2 months ago
Size Change: +60 B (+0.01%)
Total Size: 978 kB
Filename | Size | Change | |
---|---|---|---|
content/webapp/.next/static/chunks/pages/_app-b5ae32e8b8f056a5.js |
0 B | -107 kB (removed) | đ |
content/webapp/.next/static/chunks/pages/works/[workId]-d652e42a0ebf563c.js |
0 B | -25.9 kB (removed) | đ |
content/webapp/.next/static/chunks/webpack-dea3510a81c70b76.js |
0 B | -2.33 kB (removed) | đ |
identity/webapp/.next/static/chunks/pages/_app-faa942d597ee1057.js |
0 B | -100 kB (removed) | đ |
content/webapp/.next/static/chunks/pages/_app-8e21d3b65185ab02.js |
107 kB | +107 kB (new file) | đ |
content/webapp/.next/static/chunks/pages/works/[workId]-5901acae603c026e.js |
25.9 kB | +25.9 kB (new file) | đ |
content/webapp/.next/static/chunks/webpack-deff53f7207a7155.js |
2.33 kB | +2.33 kB (new file) | đ |
identity/webapp/.next/static/chunks/pages/_app-e26dcba7e8ba6935.js |
100 kB | +100 kB (new file) | đ |
What does this change?
Does an extra check on whether or not to display the cookie banner. As per #10962 , the banner has been displaying in the page builder previews and the slice simulator, as it's actually an iframe of the website.
I went for what was suggested here to figure out whether or not the document is rendered within an iframe. Had to do it through
useEffect
to accesswindow
, so there's a slight delay in hiding it iniframe
as we wanted it to display by default.How to test
Run locally, both the website (it should display the banner) and the slice simulator (it shouldn't)
How can we measure success?
We don't see the banner in the page builder previews and they're made useful again!
Have we considered potential risks?
Banner stops displaying when we need it too, which is bad, so thorough testing both locally and staging should take place.