wellcomecollection / wellcomecollection.org

🪟 Wellcome Collection's website and services that support it
https://wellcomecollection.org
MIT License
39 stars 5 forks source link

Timeboxed investigation of using the Content API of stories listing/lists #11146

Closed rcantin-w closed 1 month ago

rcantin-w commented 2 months ago

/stories, /homepage, there might be more?

We want to try using the Content API to display lists of stories, and we need to see if it's a quick job or if changes are needed on the API side.

This will unblock #11127's webcomics section.

LaurenFBaily commented 1 month ago

Agree time for timebox - half day or day?

davidpmccormick commented 1 month ago

Homepage

Stories

rcantin-w commented 1 month ago

The 'comics' section is three cards for comic serials, rather than individual comics, not including any comics from the current serial – I don't believe we can query for serials from the Content API currently

You're right, we don't allow that as series are not in Elasticsearch, so it would probably be about adding that in. I wonder if we could consider it a non-blocker for https://github.com/wellcomecollection/wellcomecollection.org/issues/11127. The Body Squabble series would show there for a while, but maybe it's not a bad thing?

The 'books' section is also managed through the 'stories landing page' in Prismic so not possible to switch out for the Content API I don't think (and even if it weren't I don't think the API currently handles books)

That's true we don't pull books in, so I think out of scope

Agree with all your other points! So it'd be about replacing:

And we think the switch could be done quite quickly/without issues then?

pollecuttn commented 1 month ago

To be discussed at planning 2 October

rcantin-w commented 1 month ago

Added warnings in https://github.com/wellcomecollection/wellcomecollection.org/issues/11127 and details in https://github.com/wellcomecollection/wellcomecollection.org/issues/11226

I think we could close this @davidpmccormick @LaurenFBaily @pollecuttn ?