search

wellcomecollection / wellcomecollection.org

🪟 Wellcome Collection's website and services that support it
https://wellcomecollection.org
MIT License
38 stars 5 forks source link

Article - Element spacing #427

Closed Norvard closed 7 years ago

Norvard commented 7 years ago

Some images in articles are bumping really close to images. There should always be 30px space in between any element e.g. paragraph, image

screen shot 2017-02-01 at 15 15 11
jamesgorrie commented 7 years ago

@Norvard - I think this was an issue with the way WP was sending copy to us. Has this been fixed? https://next.wellcomecollection.org/articles/queer-territory-claude-cahun-and-a-land-without-labels

jennpb commented 7 years ago

@jamesgorrie No, it looks like that specific issue still stands.

davidpmccormick commented 7 years ago

screen shot 2017-02-23 at 10 38 11

This specific issue is the result of the paragraph of text above the image not being contained in a <p> tag (which would give it some bottom-margin). As @jamesgorrie says, this is the result of the way the data's being delivered to us from WP. Don't know if there's anything we could do at our end to auto-wrap instances of text like this in <p> tags – not sure how we'd determine whether or not they should be wrapped (and possibly overkill given it won't be an issue when we move away from WP). Perhaps @RussellDornan can fix this instance in WP (give a shout if it needs clarifying).

jennpb commented 7 years ago

You're right @davidpmccormick it's probably not enough of an issue to worry about it just now. Just one more reason for us to move away from WP as soon as we can.

jennpb commented 7 years ago

@RussellDornan don't worry about editing this instance in WP! I'm just going to close this issue, but it's just something to be aware of in this transitional time.