wellcomecollection / wellcomecollection.org

🪟 Wellcome Collection's website and services that support it
https://wellcomecollection.org
MIT License
39 stars 5 forks source link

Improve image credit component to better handle caption and credit together #5267

Closed jennpb closed 9 months ago

jennpb commented 4 years ago

What is it and who's it for?

Editorial team

We currently use the TASL model to add a credit to images. This works fine for materials from our historical collections, but not necessarily for commissioned editorial images where the image's title is not the title of a work, but rather descriptive.

Two recent examples:

image

(this is not Kevin Percival. He's the photographer)

Screenshot 2020-04-29 at 08 16 59

Kathleen Arundell is photographer.

We need to:

Slack convo with Ben: https://wellcome.slack.com/archives/C3N7J05TK/p1587744073081300 and Alice https://wellcome.slack.com/archives/C294K7D5M/p1588144902038100

LFBaily commented 9 months ago

Not sure this is still an issue eg. some image credits have resolved this using this format:

Image

rcantin-w commented 9 months ago

It still happens here (example sent by Ben in the Slack convo) so I wonder if they've started adding "Photo:" manually to make it clearer. Might be worth a Tasl review.

I couldn't find that specific picture in your example because the Prismic media library search is horrendous, but from another picture here I can see it's been done manually;

Screenshot 2024-02-13 at 09 48 21
LFBaily commented 9 months ago

That is what I suspected, I guess the real questions is whether that's fine then.