search

wellcomecollection / wellcomecollection.org

🪟 Wellcome Collection's website and services that support it
https://wellcomecollection.org
MIT License
39 stars 5 forks source link

Green underline link vertical spacing #6277

Closed GarethOrmerod closed 3 years ago

GarethOrmerod commented 3 years ago

What is it and who's it for?

The green underline links used on type at 20px e.g. Stories main body copy has too much space below, closer to the line below than the link it relates to.

Examples:

Screenshot 2021-03-25 at 14 49 05 Screenshot 2021-03-25 at 14 48 49
davidpmccormick commented 3 years ago

Think this might be related to the Helvetica regular toggle and the vertical position of that font inside the line-height being different to the other cuts of Helvetica that are in use generally (for people who don't have the toggle turned on).

Here's how it is renders for most people: image

This is because we behave as if the mac system version and webfont versions of Helvetica are the same, when they're clearly not.

GarethOrmerod commented 3 years ago

Could the green link underlines be displayed in the same way as in the cards? They look much better and there's no conflict with descenders touching the underlines.

GarethOrmerod commented 3 years ago

Helvetica Regular - Is there anything to learn from the corporate site which has a simpler font stack and uses font-weight 700 for bold?