search

wellcometrust / grants_tagger

Tag grants with MeSH and other tags
MIT License
14 stars 4 forks source link

Add BertMesh to models so that we can tag in BioASQ #189

Closed nsorros closed 2 years ago

nsorros commented 2 years ago

Description

Adds BertMesh in models by copying and not refactoring the experimental code in BertMesh. The reason being that at this point we want to maintain moving fast in experimentation while separating what we maintain for "production". As such we do not add code to train BertMesh as this happens still in experimentation mode. Once this becomes more stable we can do that.

DVC sort of up to date.

Checklist

nsorros commented 2 years ago

The class is really nice, thanks for doing this. Can I be a massive pain and ask that you either add somewhere in the documentation the actual script/steps to tag (like the parameters passed to python scripts/tag_bioasq_test_data ? ) or add a dvc pipeline for that. Your choice.

Sure this is a good idea. Its kind of hacky at the moment.

nsorros commented 2 years ago

This is ready to go. I will run the dvc pipeline on Monday to ensure it works smoothly in the latest batch and merge.