wellcometrust / reach

Wellcome tool to parse references scraped from policy documents using machine learning
MIT License
26 stars 4 forks source link

Final UI product QA #549

Closed kristinenielsen closed 4 years ago

kristinenielsen commented 4 years ago

Hi Jason,

Would be great if you can have a final review of the product keeping in mind of all these recent changes that was made. We can talk about timings

518

j-jaworski commented 4 years ago

Below are the issues that I have spotted. I recommend that everyone get's involved in the QA before Alpha release, going through key user journeys, testing its robustness. I am sure to have missed somethings.

Visually I think it is looking good enough for release, but there are a couple of biggies IMO – the sorting, pagination and open rows do not behave as expected, I can see this causing some confusion for users.

Homepage

  1. H3 heading should be bold
  2. New Logo make smaller - same size as other pages. Looks very big here

About Reach

  1. <p> under "Open source", "Accuracy" and "Transparency" to be left-aligned

/search/citations and /search/policy-docs

  1. Increase padding left and right in button to 16px
  2. Force line breaks in H1 and H3 as below using  

Screenshot 2020-06-09 at 13.54.30.jpg

Screenshot 2020-06-09 at 13.56.33.jpg

Citations results

  1. Need hover states on pagination elements
  2. Column headers eg "Journal" should be the trigger for sorting, not just icon
  3. Can't close a row once it has expanded
  4. Sorting - icon should not change until the results have loaded
  5. loading animation timing feels off
  6. Sorting doesn't seem to rearrange the results
  7. Sorting icons need padding around them
  8. Open rows not staying open when clicked
  9. Column headers in open rows should match other column headers
  10. Next button doesn't seem to work (maybe just super slow)
  11. Pagination number eg "2" doesn't go to next page
  12. Search button on input field "Discover citations" increase padding left and right by 16px
SamDepardieu commented 4 years ago

@j-jaworski : I checked a few things:

Everything else is clear and will be fixed this week :+1:

aoifespenge commented 4 years ago

Emanuela spotted this one: https://github.com/wellcometrust/reach/issues/553

lizgzil commented 4 years ago

I hope I'm looking at the correct version (https://reach-staging.wellcomedatalabs.org/) ? Things I spotted, I think the last 2 might be for a separate discussion:

Regardless, I think it looks great and can't wait for it to be release!

j-jaworski commented 4 years ago

@SamDepardieu Thanks for going through these

• Pages changes being slow, sorting be slow and points about the animation are all related – I think having the progress bar from click for these interactions would help. We should also not change the sort icon until after the loading animation • My point about the loading animation was to do with this 👆🏻 we should if possible, keep the 2 sec delay for loading animation on the initial search as previously it was interrupting the results when it wasn't needed. • Yes only one open row at a time, but when I was opening a row it was closing of its own accord

Hope this provides some clarity, let me know if you need anything else

SamDepardieu commented 4 years ago

This should all be addressed in #556, closing