Closed kristinenielsen closed 4 years ago
Below are the issues that I have spotted. I recommend that everyone get's involved in the QA before Alpha release, going through key user journeys, testing its robustness. I am sure to have missed somethings.
Visually I think it is looking good enough for release, but there are a couple of biggies IMO – the sorting, pagination and open rows do not behave as expected, I can see this causing some confusion for users.
Homepage
bold
About Reach
<p>
under "Open source", "Accuracy" and "Transparency" to be left-aligned/search/citations and /search/policy-docs
16px
Citations results
@j-jaworski : I checked a few things:
Pages changes are slow, but I can confirm that on my side, both clicking Prev/Next buttons or a page number works. Maybe we should start the progress animation from the click for the time being, to notify the click had an effect?
On my side column headers are triggers for sorting, althouh it also is slower than it was
loading animation timing feels off
-> Are you talking about the progress bar? If so, it should be starting 2sec after an action, as requested in last QA
About rows on-click behaviour: Open rows not staying open when clicked
Should we leave opened rows open? I thought the behaviour we choose was "opening one closes the others", sorry if I missunderstood that
Everything else is clear and will be fixed this week :+1:
Emanuela spotted this one: https://github.com/wellcometrust/reach/issues/553
I hope I'm looking at the correct version (https://reach-staging.wellcomedatalabs.org/) ? Things I spotted, I think the last 2 might be for a separate discussion:
Regardless, I think it looks great and can't wait for it to be release!
@SamDepardieu Thanks for going through these
• Pages changes being slow, sorting be slow and points about the animation are all related – I think having the progress bar from click for these interactions would help. We should also not change the sort icon until after the loading animation • My point about the loading animation was to do with this 👆🏻 we should if possible, keep the 2 sec delay for loading animation on the initial search as previously it was interrupting the results when it wasn't needed. • Yes only one open row at a time, but when I was opening a row it was closing of its own accord
Hope this provides some clarity, let me know if you need anything else
This should all be addressed in #556, closing
Hi Jason,
Would be great if you can have a final review of the product keeping in mind of all these recent changes that was made. We can talk about timings
518