wellcometrust / together-science-can

Site for the Together Science Can campaign.
MIT License
1 stars 1 forks source link

✒️ JSON Schema, data + validation #35

Closed jakubfiala closed 7 years ago

jakubfiala commented 7 years ago

This PR:

@mildlydiverting requesting your review here for the JSON schema as suggested by @alfraser86 – only if you have time of course. I guess the best way for you to see what it looks like is copy this file: https://raw.githubusercontent.com/wellcometrust/together-science-can/create-json-schema-%2324/content/tsc.schema.json

and paste it here: http://jeremydorn.com/json-editor/ (just scroll down to where it says Schema, paste the json, click Update schema)

Then you can look at how I structured the data with respect to the site design: https://drive.google.com/file/d/0B79_4qOvG1qTNUNjV2RzMTN4MXc/view?usp=sharing

I'd really appreciate your opinion on whether this is a suitable level of editor freedom (even though we might end up not creating an editing interface at all)

mildlydiverting commented 7 years ago

Things that occurr to me Possible opt-in ticks/consent on the forms - we might need to add these later (depends on legal steer) - how flexible is this? Editing flexibility feels OK, generally Are you mixing social network content types in the feed? eg Instagram plus twitter? Do you need to be able to configure this - add an account? Analytics - do we need to add and configure event codes, triggers around this? What about METADATA: page descriptions, twitter card data, share images, icons etc? Partner logos should probably be clickable.

jakubfiala commented 7 years ago

thanks a lot!

Possible opt-in ticks/consent on the forms

@juliamgodinho can we check what we're doing re: this?

Are you mixing social network content types in the feed?

yep, definitely will have to be configured, but I'm not sure how yet – will add this to the schema when it comes up

Analytics - do we need to add and configure event codes, triggers around this?

yep, will solve as part of #5

What about METADATA: page descriptions, twitter card data, share images, icons etc?

good point, I'd hope they could just be hardcoded but need to check with MK if they ever change – cc @juliamgodinho

Partner logos should probably be clickable.

sure, will add a link prop to the schema

juliamgodinho commented 7 years ago

@jakubfiala @mildlydiverting

I have sent out a message out to follow up on the Possible opt-in ticks/consent on the forms and metadata. I will get back to you when I have an answer.

mildlydiverting commented 7 years ago

Just sent you an email I had drafted last night with info on law changes around consent.

From: "Julia M. Godinho" notifications@github.com Reply-To: wellcometrust/together-science-can reply@reply.github.com Date: Friday, 18 August 2017 at 10:11 To: wellcometrust/together-science-can together-science-can@noreply.github.com Cc: Kim Plowright K.Plowright@wellcome.ac.uk, Mention mention@noreply.github.com Subject: Re: [wellcometrust/together-science-can] ✒️ JSON Schema, data + validation (#35)

@jakubfialahttps://github.com/jakubfiala @mildlydivertinghttps://github.com/mildlydiverting

I have sent out a message out to follow up on the Possible opt-in ticks/consent on the forms and metadata. I will get back to you when I have an answer.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/wellcometrust/together-science-can/pull/35#issuecomment-323302217, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AANlMo54xijRP7BTVjPPTGWa_3uofJTPks5sZVUigaJpZM4O6VdX.

This message has been scanned for viruses by Websense Hosted Email Security - www.websense.com

juliamgodinho commented 7 years ago

@jakubfiala still haven't got a reply from amy regarding consent/opt in. sent a message to Lara.

And the metadata can be hardcoded.

jakubfiala commented 7 years ago

awesome, thanks!