welldone-software / gulp-durandal

Gulp plugin for building durandaljs projects
MIT License
13 stars 19 forks source link

SourceMap-Exclude #15

Closed Cotspheer closed 9 years ago

Cotspheer commented 9 years ago

When I define "generateSourceMaps: false" on the rjsConfigAdapter you still add the sourceMapUrl to the output file which occurs in an 404-Response from the server. This is an unnecessary call.

rjsConfigAdapter: function (rjsConfig) { rjsConfig.generateSourceMaps = false; return rjsConfig; }

Line 114, index.js:

text += '//# sourceMappingURL=' + path.basename(mapOutput);

Please add a check if the sourcemap is generated! Something like that:

if sourceMapText { text += '//# sourceMappingURL=' + path.basename(mapOutput); }

It's silly because you already check if you have to generate the sourceMap-file :).

vzaidman commented 9 years ago

got it. it will be fixed soon.