search

wellington / go-libsass

Go wrapper for libsass, the only Sass 3.5 compiler for Go
http://godoc.org/github.com/wellington/go-libsass
Apache License 2.0
206 stars 28 forks source link

Silent crashes #56

Open japettyjohn opened 6 years ago

japettyjohn commented 6 years ago

I'm running this in my go1.10 project in docker (alpine linux) and it started crashing with the latest master so I moved it back to fd1a2294913da5d31ccc8eea2556ccd07f89a4c8 which is working fine. Still not sure where the problem lies, but likely between commmits fdbf3052799586f07de4ffee8ca11b4f7e8bcfb4 and da42dc7f85c0d4b772af5e0a8decf6ab4e409ccb.

I was able to mitigate in one scenario without rolling back and that was by removing nested imports and just importing from the top level file.

drewwells commented 6 years ago

fdbf305 can compile on Go 1.10. Let me know if you can find a repo case. Likely issue with libsass 3.4.9

japettyjohn commented 6 years ago

Not sure on - I was using da42dc7f85c0d4b772af5e0a8decf6ab4e409ccb and that compiles on go1.10 on macOS and Alpine Linux 3.7 (musl).

Possibly musl issue but I am not sure - the crash is totally silent, no core dumps, nothing even with different traceback options - just silent exit. I was not able to reproduce that phenomena outside of docker.

drewwells commented 6 years ago

Sounds like a cgo error. Probably something is erroring and not returning a status. Does your sass successfully compile on the older version? On Sat, Feb 24, 2018 at 4:01 PM James Pettyjohn notifications@github.com wrote:

Not sure on - I was using da42dc7 https://github.com/wellington/go-libsass/commit/da42dc7f85c0d4b772af5e0a8decf6ab4e409ccb and that compiles on go1.10 on macOS and Alpine Linux 3.7 (musl).

Possibly musl issue but I am not sure - the crash is totally silent, no core dumps, nothing even with different traceback options - just silent exit. I was not able to reproduce that phenomena outside of docker.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/wellington/go-libsass/issues/56#issuecomment-368263658, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOmE0yk-39mIlH6TbTh1DmTSfGDo3Mrks5tYIa5gaJpZM4SSC62 .

japettyjohn commented 6 years ago

I had the same suspicion on cgo error. Yes, we've been running it for a while on the older version.

drewwells commented 6 years ago

We've switched to 3.5.4, can you try this code again or provide a repo case so I can verify?