search

wells-wood-research / de-stress

DE-STRESS is a model evaluation pipeline that aims to make protein design more reliable and accessible.
http://destressprotein.design
18 stars 1 forks source link

Overview Page #68

Closed ChrisWellsWood closed 3 years ago

ChrisWellsWood commented 3 years ago

@MichaelJamesStam could you take a look at this and give me some feedback? You can click the "Overview" button on the designs page to get to the overview page. Not sure it's quite right yet, I think I need to work in some responsive stuff so that it works better on desktop.

Closes #57.

ChrisWellsWood commented 3 years ago

This has changed quite significantly from the original design. Instead of a dedicated overview page, the plots are shown along side the design cards, but in order to maximise the use of space, the layout is responsive and will show either:

ChrisWellsWood commented 3 years ago

I've updated this to include aggrescan.

MichaelJamesStam commented 3 years ago

This functionality is really cool! I like that you can click on the bar charts and go to the designs page as well. These comparisons are going to be really useful! I just noticed a few minor things.

1) On the desktop view you can only see part of the "Enter new tags (comma separated)" text when you want to create a tag. 2) I think for aggrescan3d we might want to compare average score rather than total score as this is normalised for comparisons of different structures. Although I guess the energy totals aren't normalised either, so I'm not sure how much this matters. But it's quite good that we have this normalised value for aggrescan3d. 3) In the comparison plots we have DFIRE rather than DFIRE2. We have called it DFIRE2 everywhere else so I was just thinking for consistency.

Overall, these plots look really good! I think maybe just out of personal preference I prefer the plots on the different tab like on the mobile view, rather than side by side with the design list. But I see the advantage of having them side by side as well.

ChrisWellsWood commented 3 years ago

Merging this now. Regarding your points, I think we should keep the raw value for aggrescan as we've not normalised any of the other, and regarding 2 and 3, I've fixed them in another branch.