search

wellsjo / JSON-Splora

GUI app for editing, visualizing, and manipulating JSON data
MIT License
1.86k stars 60 forks source link

Linter is not working correctly #19

Closed wellsjo closed 7 years ago

wellsjo commented 7 years ago

The editor input type needs to dynamically switch from JavaScript to JSON.

vpillinger commented 7 years ago

I tried this and the bigger problem is that turning on the JSON linter will show errors on comments. However, some people might want comments in the data sets which they are using for this type of application. Therefore, we either need to say NO to comments, or find/write a linter that will allow comments.

Edit: I found a json5 linter and I will attempt to integrate it instead of the current JSON linter: https://www.npmjs.com/package/grunt-json5lint

wellsjo commented 7 years ago

@vpillinger you outlined the problem exactly. I 100% want to keep comments, but I couldn't get the linter to not show errors when they were present. json5 is definitely the way to go, since that is already how I'm parsing/validating the editor input. I didn't realize it has a linter.

wellsjo commented 7 years ago

fixed by #30