search

wellsjo / JSON-Splora

GUI app for editing, visualizing, and manipulating JSON data
MIT License
1.86k stars 60 forks source link

Added theme submenu for view. Theme changes when menu is clicked. #22

Closed vpillinger closed 7 years ago

vpillinger commented 7 years ago

First pass at adding a changeable theme. This was my first crack at using electron so please review what I did carefully. I had to move the main menu creation into the Render process to enable the theme change callback to work.

In my opinion, the next logical steps on the themes is to create a class that manages the theme submenu. The class can build and return the submenu for themes based on the available themes. It can also hold the function for the App callback to change theme, as well as add some nice functionality such as managing checking & unchecking of the currently selected theme.

Issue Link: https://github.com/wellsjo/JSON-Splora/issues/13

wellsjo commented 7 years ago

Nice work, I added some comments and changed a couple style-related things. You only forgot to change the output theme.