search

wellsjo / JSON-Splora

GUI app for editing, visualizing, and manipulating JSON data
MIT License
1.86k stars 60 forks source link

Theme cleanup, Fixed Linting, Added Bracket Highlighting #30

Closed vpillinger closed 7 years ago

vpillinger commented 7 years ago

Cleaned up the code surrounding theme changes. Created a MainMenu class for the purpose of consolidating Menu related code. Also made the menu interface look a little more professional.

Note: Code Mirror allows multiple themes at once, and I thought about implementing this in the menu, but decided against implementing it for now.

Issues resolved: https://github.com/wellsjo/JSON-Splora/issues/1

vpillinger commented 7 years ago

I updated the title to reflect what is in my branch now. I incorporated those style fixes. I added bracket matching. I also fixed the linter by registering a helper with CodeMirror. Currently, I am just running the parser and returning the errors if any were found. The thing is that the red underline is either going to be 1 character, or the entire document, since the parser isn't really a good linter on its own. However, it is certainly better than no linter :).

Also, about the color change. Go for it, but keep in mind that not all themes will override the default color for the highlighting. So it might make some themes look weird.

Updated Issues Resolved: https://github.com/wellsjo/JSON-Splora/issues/1 https://github.com/wellsjo/JSON-Splora/issues/19

wellsjo commented 7 years ago

Awesome! Checking this out now. We can fix the colors later 😄

wellsjo commented 7 years ago

I fixed a few style things and changed MainMenu to use class syntax. Merging for now, the rest can be added later!

MaanooAk commented 7 years ago

If don't want I could fix these issues in a separate pull request

wellsjo commented 7 years ago

@MaanooAk hey, sorry that was really sloppy, I'm fixing in a separate pr