wellsjo / JSON-Splora

GUI app for editing, visualizing, and manipulating JSON data

MIT License

1.86k stars 60 forks source link

Url resolution & menu bugs #37

Closed MaanooAk closed 7 years ago

MaanooAk commented 7 years ago

Added url resolution on paste (based on #10).

Fill free to change anything (names, filenames...), just wanted to add the basic functionality open to possible refactoring.

MaanooAk commented 7 years ago

Resolved conflicts (was really hard for some reason)

wellsjo commented 7 years ago

@MaanooAk probably because I just introduced eslint 😬 sorry

MaanooAk commented 7 years ago

41 should close after this. (check last commit)

MaanooAk commented 7 years ago

Last commits removes the template[1].submenu[7].submenu = ... with fixed indexes (which has already caused enough problems).

MaanooAk commented 7 years ago

Fixing the validation errors now...

wellsjo commented 7 years ago

Nice, thank you for that. I haven't gotten the url resolution regex to work, perhaps we could leverage another library that has solved this problem such as https://github.com/ogt/valid-url?

MaanooAk commented 7 years ago

Wait, you mean it doesn't work for you? (note: it has to be one line starting with http:// or https://) Try copy this http://maanoo.com/projects/data.json and go to the app select all -> paste so we have the same testing env.

wellsjo commented 7 years ago

I see, yeah that was the issue. Thanks for cleaning up the validation errors! I'm down to merge this for now. We can improve it over time.