Tabs Functionality - Githubissues

wellsjo / JSON-Splora

GUI app for editing, visualizing, and manipulating JSON data

MIT License

1.86k stars 60 forks source link

Tabs Functionality #70

Closed kylealwyn closed 7 years ago

kylealwyn commented 7 years ago

Heyo! I just wanted to get this up here to get some review as there is a paradigm shift in how tabs are created. Would love to get some feedback and am open to any suggestions!

Features

Multiple tab instances
Cmd+T to open new tab
Cmd+O opens file in new tab

Considerations

Moved from Page to Tabs/Tab relationship
App does not control creation of tabs

Todo

Rewrite tests to incorporate new functionality
Tabs class needs to store activeTab when maneuvering between tabs

wellsjo commented 7 years ago

I like what you've done here! I have a couple comments/suggestions:

Maybe don't show the tabs if there is only one. It takes up a lot of screen real estate
Command / Control + W should close tabs, not the whole application
You should be able to click x on the active tab

Also, can you rebase? It will fix a couple things

kylealwyn commented 7 years ago

Implemented your changes and suggestions. Totally agree! Hopefully I can get to some tests tomorrow

wellsjo commented 7 years ago

@kylealwyn I added some comments and am thinking about a couple style changes. can you rebase with my master branch? then this is good to go

kylealwyn commented 7 years ago

Awesome. I can possibly get this done tomorrow morning before snowshoeing, if not then Sunday night.

Kyle Alwyn Software Engineer | Lemonaid Health Healthcare. Refreshingly Simple.

On Fri, Dec 16, 2016 at 3:34 PM -0800, "Wells Johnston" notifications@github.com wrote:

@kylealwyn I added some comments and am thinking about a couple style changes. can you rebase with my master branch? then this is good to go

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

This message may contain information which is legally privileged and confidential. If you are not the intended recipient any unauthorized disclosure, copying, retention or use of this information is strictly prohibited.

wellsjo commented 7 years ago

I don't have a problem doing it and then merging, I just didn't want to mess up any work you were doing with a git push --force

kylealwyn commented 7 years ago

Rebased