Windows node-jq and jq fix

wellsjo / JSON-Splora

GUI app for editing, visualizing, and manipulating JSON data

MIT License

1.86k stars 60 forks source link

Windows node-jq and jq fix #72

Closed MaanooAk closed 7 years ago

MaanooAk commented 7 years ago

node-jq v.0.5.0 now supports windows
jq has a limit to the length of the arguments, I changed the path of the tmp file from absolute to relative (= smaller) and it works.

This pr resolves all jq issues in Windows (#56 and others?)

wellsjo commented 7 years ago

LGTM 👍

wellsjo commented 7 years ago

@MaanooAk this ended up causing it not to work on Mac. we need to find a better solution, or at least something that separates the tmp path for both operating systems.

MaanooAk commented 7 years ago

I have no experience with mac, I am sorry I can't help (or test)... but using the old way for mac and the new way for everything else should be easy to implement. Can you test on mac?

wellsjo commented 7 years ago

@MaanooAk Yeah I will try that today. Been really busy lately so I didn't even notice.