search

wellsjo / JSON-Splora

GUI app for editing, visualizing, and manipulating JSON data
MIT License
1.86k stars 60 forks source link

Added search addons. #73

Open vpillinger opened 7 years ago

vpillinger commented 7 years ago

Included dialog addons for pretty search dialogs. #58

wellsjo commented 7 years ago

Can we improve the UX a bit here? Searching from the command line doesn't work, for example. I don't think simply enabling CodeMirror's search is enough.

vpillinger commented 7 years ago

I agree with you that the default code-mirror UX is pretty ugly, requiring Cmd+G to browse through results. So this PR doesn't finish the search feature, but it certainly moves it in the right direction while someone can work on improving the dialog boxes. Also, don't know what you mean about searching from the command line. The CLI is right now only a shortcut to open a file. Why wouldn't a user just open the file then press Ctrl+F or Cmd+F to search after opening the file? I think there is a use-case here that I am not seeing.

wellsjo commented 7 years ago

Hey sorry this took so long for me to get to, I was away for a while. Could you rebase and then I will check it out/merge?