search

welovecoding / editorconfig-netbeans

A NetBeans IDE plugin supporting the EditorConfig standard. ⛺
https://editorconfig.org/
MIT License
126 stars 22 forks source link

Normalize line endings #95

Closed Shredder121 closed 8 years ago

Shredder121 commented 8 years ago

Sorry to start off with such a big commit, but I noticed that not all line endings were normalized.

Shredder121 commented 8 years ago

It's at least a step in the right direction (to have a .gitattributes file and enforce line endings), I very much respect that, I also do it on my projects :wink:

Let me know what you think.

bennycode commented 8 years ago

Hello @Shredder121 and thank you for your contribution.

We have enforced line endings: https://github.com/welovecoding/editorconfig-netbeans/blob/master/.gitattributes#L4

So what was wrong with them?

Shredder121 commented 8 years ago

Hi! The commit that introduced the normalization(or rather the enforcement of normalization) didn't actually normalize the line endings. Has anything changed in the meantime? I can renormalize the line endings if you want.

Shredder121 commented 8 years ago

Nothing has changed, so it should apply as-is.

Shredder121 commented 8 years ago

It's better to normalize the line endings up front, otherwise the next change applied will introduce unnecessary whitespace changes.

Shredder121 commented 8 years ago

So I take it that this change is not wanted? When I cloned the repository initially, git said I had unstaged changes. This will also happen to others, presumably.