search

welovedevs / react-ultimate-resume

💼 🎨 A modern software developer resume built with React and JSONResume
https://welovedevs.com/react-ultimate-resume
GNU Affero General Public License v3.0
2.12k stars 625 forks source link

Bug: Dependance Error #63

Closed romain325 closed 3 years ago

romain325 commented 4 years ago

NPM Error Message:

Failed to compile.

./node_modules/@welovedevs/ui/popper_card/popper_card.js
Module not found: Can't resolve '../assets/icons/speech_bubble_arrow.svg' in '/home/romain/prog/website/react-ui/node_modules/@welovedevs/ui/popper_card'

Apparently it is a quiet simple correction to do, I just haven't looked where the code of "@welovedevs/react-ultimate-resume/" is and how I can modify it

Tested on: Default project (git clone) and personal project(npm i)

I might pull later, any help on where are the files is always pleasant! Thanks a lot

romain325 commented 4 years ago

Changed package.json and put "@welovdevs/ui" to the latest (1.1.0) and fixed this issue However another issue appeared;

Warning: useLayoutEffect received a final argument that is not an array (instead, received `object`). When specified, the final argument must be an array.
    in ProfileCardComponent (at soundtrack_card.jsx:40)
    in SoundtrackCardComponent (created by CardsComponent)

Seems like a problem with react-spring useTransition()

clementdevos commented 4 years ago

Hi @romain325

As explained here https://github.com/welovedevs/react-ultimate-resume/issues/48#issuecomment-644036760, we're waiting on react-spring to be in a stable version (ie. v9.0.0) to update it as it's not yet stable, which is kind of a pain in the ...

We're updating our ui lib to typescript, leading to your issue with the missing .svg file.

Can you please downgrade the @welovedevs/ui to the v1.0.5-beta.11 version which is not using typescript yet? Also make sure to use node v12 for now... I'll fix everything up (react-spring and our design system) when react-spring is stable.

https://github.com/react-spring/react-spring/milestone/1

romain325 commented 4 years ago

No problem thanks a lot for the support !
If any help is needed, it will be a pleasure :) (btw in the ui I think there is a little typo: ancient version was "@welovdevs/ui/styles/pallettes.js" and the new is "styles/pallette.ts")

clementdevos commented 3 years ago

closing this in favor of #48