search

welovedevs / react-ultimate-resume

💼 🎨 A modern software developer resume built with React and JSONResume
https://welovedevs.com/react-ultimate-resume
GNU Affero General Public License v3.0
2.12k stars 625 forks source link

Homepage doesn't display properly when serving production build locally #67

Closed sheriffyusuf closed 3 years ago

sheriffyusuf commented 3 years ago

It displays properly only when running with development build. Attached below is screenshot of production build served locally.

Screenshot from 2020-10-31 15-49-06

mohshbool commented 3 years ago

i'm having the same issue here. using node v12.10 to build & serve

clementdevos commented 3 years ago

Hi,

We've gone back and forth with Material UI and JSS providers. We have two injection points in the index.html 

      <!-- mui-insertion-point -->

        <!-- jss-insertion-point -->

They ensure the CSS is injected in the right point.

These comments are deleted by react-scripts in production mode, breaking the css injection order (cf https://github.com/facebook/create-react-app/issues/4245) , i'm trying to work around this. Sorry about that !

clementdevos commented 3 years ago

It's fixed on develop :)

Have a nice day :)

roboflank commented 3 years ago

@clementdevos the fix to this seems to have been deleted https://github.com/welovedevs/react-ultimate-resume/commit/ff38f984d4f72ab726829705c66508e2ab3e4a0e

Had the same issue but adding the block fixes it. https://github.com/welovedevs/react-ultimate-resume/commit/983ee0001d3c162b8af2ee828a171434ccd710d3#diff-ec767e14d91498b5b31a4ce826c4596061eb83a47d3dee00f6cbe1078232a75c

clementdevos commented 3 years ago

Jeez i work on this alone and i managed to break it alone.

Will fix it asap.

clementdevos commented 3 years ago

There, i've added it back to develop. So sorry about this.