welpdev / mailchimp-bundle

MailChimp integration with Symfony and MailChimp API V3
https://welpdev.github.io/mailchimp-bundle/
MIT License
44 stars 36 forks source link

fix #19 use legacy symfony services declaration. #27

Closed yfrommelt closed 5 years ago

SalvatorePollaci commented 5 years ago

Any news on this PR being accepted?

Nightbr commented 5 years ago

Tests are failing. Add to that this is not the best practice recommanded by Symfony. If you want to use service name instead of class, use alias https://symfony.com/doc/current/service_container/alias_private.html

jeroendk commented 5 years ago

@Nightbr Don't think this is true for Bundles though: https://symfony.com/doc/current/bundles/best_practices.html#services