search

welpo / tabi

A modern Zola theme with search, multilingual support, optional JavaScript, a perfect Lighthouse score, and a focus on accessibility.
https://welpo.github.io/tabi/
MIT License
97 stars 32 forks source link

🐛 fix(i18n): atom feed page direction for RTL langs #268

Closed TheAwiteb closed 4 months ago

TheAwiteb commented 4 months ago

Fix https://github.com/welpo/tabi/issues/267

The page will looks like this after this PR

[!NOTE] I change the language from English to Arabic, to see the page in LTR and RTL

https://github.com/welpo/tabi/assets/59842932/a7575de0-fa67-4c09-aa1d-b4fae813a759

welpo commented 4 months ago

Thank you!

welpo commented 4 months ago

I'm curious, did you test if this auto option also works for the main template? As an alternative fix to #262.

TheAwiteb commented 4 months ago

I'm curious, did you test if this auto option also works for the main template? As an alternative fix to #262.

It's should work, but in Arabic and I think also in other languages we (as individuals) may start the line with English word, so this will destroy the entire page.

If auto are risky like this, why I used it here?

Because the start content of the feed page can't be changed. You can change it but you need then edit it on the translation file, I think who will do this he knows what he do

welpo commented 4 months ago

Awesome! Thanks for testing and for the clear explanation!! 🫶