welpo / tabi

A modern Zola theme with search, multilingual support, optional JavaScript, a perfect Lighthouse score, and a focus on accessibility.
https://welpo.github.io/tabi/
MIT License
112 stars 36 forks source link

🌐 feat(i18n): add Dutch language #290

Closed Myrdincx closed 5 months ago

Myrdincx commented 5 months ago

Summary

Related issue

Changes

Accessibility

Screenshots

Type of change

Checklist

Haven't tested it out, but it should be fine, I assume? I can test if needed.

Myrdincx commented 5 months ago

For some reason I'm unable to test out if it works. I tried creating a /i18n/ directory on the test website I'm using, following the "Lost in Translation" instructions but the website doesn't seem to pick the language up. Resulting in everything being in English and the "change language" button not showing

welpo commented 5 months ago

Hi @Myrdincx!

Thank you for this PR. I will test it as soon as I can (next week) before merging.

The custom i18n file should work, so I will check that out as well.

Cheers

Myrdincx commented 5 months ago

I probably did something wrong but I have no clue what. What I did:

Result: Website did build and was accessible but everything was in English, the option to change languages was not available

welpo commented 5 months ago

Did you add any actual posts in nl? E.g. files like content/blog/faq-languages/index.nl.md.

In any case, I was able to test it locally with these steps:

Thank you for your contribution!