Dalker commented 2 months ago

Summary

Fix the "All posts" link, which used to be hard-coded to link to the section "blog", which may not actually exist or not be the desired target of this link.

Related issue

292

Changes

Changes were made to two templates:

macros/list_posts : this is the incriminated macro, that had a hardcoded "blog" string; this was left as a default value when adding a new parameter to fix the issue, although that default parameter should in principle never be actually used
section : the call to the previous macro is changed to reflect the current section's path
note that 3 other files where found that call the list_posts macro, but experimentation shows that they are not involved in the bug we're trying to fix, as no "All posts" link is generated by their calls to list_posts; they therefore do not need to bother creating and sending a section path, the default "blog" is enough, since it will not be actually used

Accessibility

Nothing done in this respect as this is just a minor change to some internals.

Screenshots

N/A

Type of change

[x ] Bug fix (fixes an issue without altering functionality)
[ ] New feature (adds non-breaking functionality)
[ ] Breaking change (alters existing functionality)
[ ] UI/UX improvement (enhances user interface without altering functionality)
[ ] Refactor (improves code quality without altering functionality)
[ ] Documentation update
[ ] Other (please describe below)

Checklist

[ ] I have verified the accessibility of my changes
[ ] I have tested all possible scenarios for this change
[ ] I have updated theme.toml with a sane default for the feature
[ ] I have made corresponding changes to the documentation:
- [ ] Updated config.toml comments
- [ ] Updated theme.toml comments
- [ ] Updated "Mastering tabi" post in English
- [ ] (Optional) Updated "Mastering tabi" post in Spanish
- [ ] (Optional) Updated "Mastering tabi" post in Catalan

welpo commented 2 months ago

Thank you for the PR!

I will review it in a few days.