Open sam9032 opened 2 weeks ago
Name | Link |
---|---|
Latest commit | c5501956418b096ded6fe57a786f6d71f644ad43 |
Latest deploy log | https://app.netlify.com/sites/tabi-demo/deploys/66749a78ee7b290008167db9 |
Deploy Preview | https://deploy-preview-330--tabi-demo.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
There are still open tasks:
Thanks for working on this!
I've:
post_listing_date
I have also changed the formatting a bit, removing the separator.
I think this looks cleaner. What are your thoughts?
An alternative that looks even cleaner, to my eyes, without any losses, is changing "Last updated on" to "Updated on". The message is the same, but it looks neater:
This would require changing all i18n strings (I'd do that on another PR), and I could use the opportunity to use string substitution, as not all languages use the $updated_string + $date
format, but rather $date + $updated_string
.
What are your thoughts on the current redesign (sans the separator)? And how about the shortened version ("Updated on" instead of "Last updated on"?
Thank you!
What are your thoughts on the current redesign (sans the separator)?
With a wide screen this would be my preferred design too but I don't like the design on smaller screens. That was the reason I added the separator:
And how about the shortened version ("Updated on" instead of "Last updated on"?
I like that one!
With a wide screen this would be my preferred design too but I don't like the design on smaller screens. That was the reason I added the separator
Aah great catch! I'll do a separator only for mobile/narrow screens, then!
Done! I've modified config.toml
so you can see it live on the demo: https://deploy-preview-330--tabi-demo.netlify.app/
It is looking great now. Thank you!
There is an error now, if there is no "updated" date in the blog post π€
Thanks for the catch and fix!
I'll try to do some thorough testing and write the docs this week, then we can merge :)
There are still open tasks:
* documentation * rss / atom site that implements the new options
Done! You can see it in the PR demo.
Could I ask you to do some final testing, trying to break the feature, before we merge?
Thank you so much!
I would love to test it. I'll be away for a week from now and pretty much offline, unfortunately I won't be able to work on it until after that.
On Thu, 2024-06-20 at 14:11 -0700, Γscar wrote:
There are still open tasks:
documentation
rss / atom site that implements the new options Done! You can see it in the PR demo [1]. Could I ask you to do some final testing, trying to break the feature, before we merge? β Reply to this email directly, view it on GitHub [2], or unsubscribe [3]. You are receiving this because you authored the thread.Message ID: @.***>
[1] PR demo https://deploy-preview-330--tabi-demo.netlify.app/ [2] view it on GitHub https://github.com/welpo/tabi/pull/330#issuecomment-2181568712 [3] unsubscribe https://github.com/notifications/unsubscribe-auth/AC6OX3RWBHD3VTNLIMHNUXTZINAPZAVCNFSM6AAAAABJLDJNLKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBRGU3DQNZRGI
No worries! There's no rush.
Hey @sam9032! I added the i18n update in #342.
If we can double check this PR is bug-free, I'll merge :)
Summary
This pull request adds an option to the config.toml to change the displayed dates on the bloglist.
Related issue
326
Changes
config.toml
Accessibility
Screenshots
See the dates on the left side
Option bloglist_date = "updated":
Option bloglist_date = "date":
Option bloglist_date = "both":
Type of change
Checklist
config.toml
(post_listing_date
should be"date"
)theme.toml
with a sane default for the featureconfig.toml
commentstheme.toml
comments