✨ feat(admonitions): allow swapping admonition icons - Githubissues

welpo / tabi

A modern Zola theme with search, multilingual support, optional JavaScript, a perfect Lighthouse score, and a focus on accessibility.

https://welpo.github.io/tabi/

MIT License

97 stars 32 forks source link

✨ feat(admonitions): allow swapping admonition icons #340

Closed welpo closed 6 days ago

welpo commented 6 days ago

Summary

This PR adds the ability to customise icons for admonitions.

Related issue

Resolves #337.

Changes

Updated admonition shortcode to accept a custom icon parameter
Modified CSS to support custom icons while maintaining existing styles
Added documentation for the new icon customization feature

Accessibility

The changes maintain the existing accessibility features of admonitions.

Screenshots

Type of change

[ ] Bug fix (fixes an issue without altering functionality)
[x] New feature (adds non-breaking functionality)
[ ] Breaking change (alters existing functionality)
[ ] UI/UX improvement (enhances user interface without altering functionality)
[ ] Refactor (improves code quality without altering functionality)
[ ] Documentation update
[ ] Other (please describe below)

Checklist

[x] I have verified the accessibility of my changes
[ ] I have tested all possible scenarios for this change
[ ] I have updated theme.toml with a sane default for the feature
[x] I have made corresponding changes to the documentation:
- [ ] Updated config.toml comments
- [ ] Updated theme.toml comments
- [ ] Updated "Mastering tabi" post in English
- [ ] (Optional) Updated "Mastering tabi" post in Spanish
- [ ] (Optional) Updated "Mastering tabi" post in Catalan

netlify[bot] commented 6 days ago

Deploy Preview for tabi-demo ready!

Name	Link
Latest commit	53d520daa7a071de52f8a941d78b8545194c2777
Latest deploy log	https://app.netlify.com/sites/tabi-demo/deploys/667db819eaa4510008d3196a
Deploy Preview	https://deploy-preview-340--tabi-demo.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.