welpo / tabi

A modern Zola theme with search, multilingual support, optional JavaScript, a perfect Lighthouse score, and a focus on accessibility.
https://welpo.github.io/tabi/
MIT License
97 stars 32 forks source link

feat: optional alternative tags sort order based on posts count #344

Closed metaleap closed 4 days ago

metaleap commented 4 days ago

Summary

Adds new variable tag_sorting with two options: name (default) and frequency (new).

Related issue

Implements feature request: #341

Type of change


Checklist

netlify[bot] commented 4 days ago

Deploy Preview for tabi-demo ready!

Name Link
Latest commit 0f88ece9b1b77cad5d74040587f0985b40c57bc5
Latest deploy log https://app.netlify.com/sites/tabi-demo/deploys/66802a494ae13700085381be
Deploy Preview https://deploy-preview-344--tabi-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

welpo commented 4 days ago

Nice! Looks good.

I wanted to push the Mastering tabi translations + a bit of setting validation (so users don't try a setting that doesn't exist and wonder why it's not working). It failed, which makes me think I don't have permission to edit your branch.

Would it be possible for you to change this? If you prefer, I can also paste the diffs here so you can make the changes yourself.

metaleap commented 4 days ago

It failed, which makes me think I don't have permission to edit your branch.

I just explicitly "added" you as member with admin privs to that fork repo, hopefully it'll now let you?

welpo commented 4 days ago

After some battles with git, I managed.

Merging now. Many thanks!