weltevrede / psrsalsa

PSRSALSA: A Suite of ALgorithms for Statistical Analysis of pulsar data. Please refer to the following website for dowload instructions and a tutorial:
http://www.jb.man.ac.uk/research/pulsar/Resources/psrsalsa.html
BSD 3-Clause "New" or "Revised" License
5 stars 6 forks source link

latest psrsalsa throws an error during compilation of fitting.c #3

Closed mserylak closed 5 years ago

mserylak commented 5 years ago

When compiling latest psrsalsa code I get the following error:

$> ~/software/psrsalsa> make gcc -Isrc/lib/ -I/usr/lib/pgplot5 -I/local/scratch/wltvrede/puma1soft/trunk/src/Soft/cfitsio/include/ -I src/slalib/ -Wall -g -DGSL_VERSION_NUMBER=115 -c -o src/lib/fitting.o src/lib/fitting.c src/lib/fitting.c: In function ‘fit_levmar_internal’: src/lib/fitting.c:632:42: error: ‘gsl_multifit_fdfsolver {aka struct <anonymous>}’ has no member named ‘J’ gsl_multifit_covar(gsl_params->solver->J, 0.0, gsl_params->covar); Makefile:87: recipe for target 'src/lib/fitting.o' failed make: *** [src/lib/fitting.o] Error 1

weltevrede commented 5 years ago

Hi Maciej,

This error looks familiar. The compilation line defines the gsl version to be 1.15 (|-DGSL_VERSION_NUMBER=115|). This information is used in the code, since gsl is unfortunately not backwards compatible.... I think you must be compiling this with a different version of gsl. Let me know if this solved, or not solved, the problem.

Cheers, Patrick

On 02/01/2019 13:26, Maciej Serylak wrote:

When compiling |psrsalsa| I get the following error:

|$> ~/software/psrsalsa> make| |gcc -Isrc/lib/ -I/usr/lib/pgplot5 -I/local/scratch/wltvrede/puma1soft/trunk/src/Soft/cfitsio/include/ -I src/slalib/ -Wall -g -DGSL_VERSION_NUMBER=115 -c -o src/lib/fitting.o src/lib/fitting.c src/lib/fitting.c: In function ‘fit_levmar_internal’:| |src/lib/fitting.c:632:42: error: ‘gsl_multifit_fdfsolver {aka struct

}’ has no member named ‘J’ gsl_multifit_covar(gsl_params->solver->J, 0.0, gsl_params->covar);| |Makefile:87: recipe for target 'src/lib/fitting.o' failed| |make: *** [src/lib/fitting.o] Error 1| — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub , or mute the thread .

-- Dr. Patrick Weltevrede, senior lecturer in pulsar astrophysics Jodrell Bank Centre for Astrophysics, School of Physics and Astronomy, University of Manchester

Office 3.210 Alan Turing Building Tel: +44 (0) 16127 54162 Website: http://www.jodrellbank.manchester.ac.uk/

mserylak commented 5 years ago

Hi Patrick,

Thank you, it worked! Editing Makefile and changing version of GSL did the trick. Closing the issue.

mserylak commented 5 years ago

Issue can be closed.