weltmeyer / ha_sonnenbatterie

Homeassistant integration to show many stats of Sonnenbatterie
GNU General Public License v3.0
51 stars 24 forks source link

Split out `battery_system` sensors (fixes #28) #29

Closed RustyDust closed 1 year ago

RustyDust commented 1 year ago

After contemplating this a bit I think it makes sense to provide separate settings for the values under battery_settings and inverter['status']. This makes it easier to cater for different setups of the whole system and gives the users more flexibility. Changes in this PR:

weltmeyer commented 1 year ago

Thanks for all that fixes! As i am not having an inverter i assume these values are now working correctly :)

TobyRh commented 1 year ago

Thanks for all that fixes! As i am not having an inverter i assume these values are now working correctly :)

Updated yesterday and everythings working as expected :)

RustyDust commented 1 year ago

@weltmeyer

Before I send another PR and to prevent you from a possible heart attack ... mind looking at this

weltmeyer commented 1 year ago

That is something i wanted to do for a long time, moving the map out of the code. But my python knowledge is not that advanced xD.

Just looking for some things.. BackupBuffer is 0 for me, while usoc=0 and rsoc=700. That is where my 7% assumption came from. calc_restrictedcapacity would be zero for me...

RustyDust commented 1 year ago

Ok, then I'll fire off the PR and we can discuss things there ;)