Some meters report a value of `undefined` when their actual value is `0`

[RustyDust]

@Xitee1 Since the update I'm seeing these meters report undefined when their actual value should be 0:

• meter_production_a_l1
• meter_production_a_l2
• meter_production_a_l3
• meter_production_w_l1
• meter_production_w_l2
• meter_production_w_l3
• 'meter_production_w_total

To me this looks like a division by zero error somewhere in the code but I can't find any logs to that effect.

[Xitee1]

Probably is not None needs to be appended to this check https://github.com/weltmeyer/ha_sonnenbatterie/blob/22483c9c398fd5e51b85ec7d3648ce34ee17352a/custom_components/sonnenbatterie/sensor_list.py#L70 I'll try it tonight.

[RustyDust]

I'd rather try

    else 0

here

'cause I think the None is what causes the undefined result.

[Xitee1]

But then if the value is actually None for whatever reason, the sensor will still be set to 0 (and created if it does not exist). Because the powermeters are a hardcoded list, there is a possibility that they are just not supported. With else 0 they will still be created in HA, which they will not if we return None if the reported value is equal None.

[Xitee1]

cause I think the None is what causes the undefined result.

exactly, which is good if returned correctly.

[RustyDust]

Try running

print("bla") if (val := 0) else print("blubb")

;)

[Xitee1]

>>> print(val if (val := 0) else 0)
0
>>> print(val if (val := None) else 0)
0

...which means that if the val is None (if e.g. the sensor is not supported), 0 will be reported instead of None, which is wrong.

This is what we want:

>>> print(val if (val := 0) is not None else None)
0
>>> print(val if (val := None) is not None else None)
None

[RustyDust]

Ah, sorry. I skimmed over your initial statement about the possibility of those meters not being supported. I have yet to find a system that doesn't but if there are this is definitely the cleaner solution.

[Xitee1]

Hat jetzt leider doch etwas länger gedauert, hab aber gerade den PR erstellt.

[RustyDust]

NP, bin auch nicht dazu gekommen