search

wemake-services / caddy-gen

Automated Caddy reverse proxy for docker containers
https://hub.docker.com/r/wemakeservices/caddy-gen
MIT License
250 stars 24 forks source link

Enable websocket proxying #12

Closed theminecoder closed 6 years ago

theminecoder commented 6 years ago

This allows apps like TeamCity to use their internal web socket features.

theminecoder commented 6 years ago

On caddys end all this preset does is enable 2 headers to be forwarded (as shown here) so this shouldn't break anything that doesn't use websockets, so I think it's safe to have this enabled globally.

I am happy to make a label option to turn it off, just in case it does break something however.

sobolevn commented 6 years ago

@theminecoder thanks for the clarification. It still makes sense to me to make it optional.

theminecoder commented 6 years ago

All done! You should just need to add virtual.websockets as a label and it will add the websocket preset.