wemake-services / dotenv-linter

:relaxed: Linting dotenv files like a charm!

https://dotenv-linter.rtfd.io

MIT License

276 stars 9 forks source link

#12: Add tests for violation codes and docs #711

Closed nifadyev closed 1 month ago

nifadyev commented 1 month ago

I have made things!

Checklist

[x] I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)
[x] I have created at least one test case for the changes I have made
[ ] I have updated the documentation for the changes I have made
[x] I have added my changes to the CHANGELOG.md

Related issues

Closes #12 Based on PR #88

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.28%. Comparing base (460b6fe) to head (e13f5a7). Report is 77 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #711 +/- ## ========================================== - Coverage 97.62% 97.28% -0.34% ========================================== Files 22 22 Lines 463 479 +16 Branches 74 95 +21 ========================================== + Hits 452 466 +14 - Misses 8 10 +2 Partials 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nifadyev commented 1 month ago

@sobolevn , could you please help with passing the test test_all_violations_are_final on python 3.9-3.10. Docs on final decorator says that attribute __final__ is available since 3.11. It is the reason the test fails. But cannot find the reason the same test with same python 3.9 passes in wamake-python-styleguide i've tried import final from typing_extensions, no luck

sobolevn commented 1 month ago

I use typing_extensions for final import. https://github.com/wemake-services/wemake-python-styleguide/blob/master/wemake_python_styleguide/violations/best_practices.py#L176

But, make sure that typing_extensions has the latest version.

nifadyev commented 1 month ago

Hey @sobolevn , PR fails codecov project check because of unrelated coverage drop (see report). As I can see, file version.py in wemake-python-styleguide differs from the one from dotenv-linter. Maybe the issue with RTD is not relevant no more? I found commit back in 2022 where you dropped this logic for wemake-python-styleguide