search

wemake-services / flake8-eradicate

Flake8 plugin to find commented out or dead code
https://pypi.org/project/flake8-eradicate/
MIT License
310 stars 12 forks source link

The "setuptools" requirement should be explicitly defined (ModuleNotFoundError: No module named 'pkg_resources'). #244

Closed AlirezaRoshanzamir closed 2 years ago

AlirezaRoshanzamir commented 2 years ago

Due to the usage of the "pkg_resources" module, the "setuptools" requirement should be explicitly defined (in this project, it is runtime requirement as well as installation time requirement). Because there are tools (such as Pants) that, after installing the library, do not maintain the installation time requirements, hence, this error is given:

ModuleNotFoundError: No module named 'pkg_resources'

which raises this exception on the Flake8:

flake8.exceptions.FailedToLoadPlugin: Flake8 failed to load plugin "E8" due to No module named 'pkg_resources'.
sobolevn commented 2 years ago

@AlirezaRoshanzamir PR is welcome!

AlirezaRoshanzamir commented 2 years ago

@sobolevn The pull-request is created.

AlirezaRoshanzamir commented 2 years ago

@sobolevn Thanks for accepting the pull request.

Is there a specific timeline for the next release? Or can this change be released as version 1.2.1?

sobolevn commented 2 years ago

1.2.1 is released.