search

wemake-services / flake8-eradicate

Flake8 plugin to find commented out or dead code
https://pypi.org/project/flake8-eradicate/
MIT License
310 stars 12 forks source link

Migrate from pkg_resources to importlib.metadata #249

Closed wwuck closed 2 years ago

wwuck commented 2 years ago

This migrates from deprecated pkg_resources to the stdlib importlib.metadata. Python version is also updated to minimum 3.7 as 3.6 is now EOL.

I'm not sure why flake8 version in poetry.lock was lowered by poetry.

I ran poetry remove setuptools and poetry add --python "<3.8" importlib_metadata to swap the dependency. I am running poetry on python3.10.

Fixes #248

codecov[bot] commented 2 years ago

Codecov Report

Merging #249 (d551827) into master (385c8ed) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head d551827 differs from pull request most recent head d6f7de9. Consider uploading reports for the commit d6f7de9 to get more accurate results

@@            Coverage Diff            @@
##            master      #249   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           42        43    +1     
  Branches         8         8           
=========================================
+ Hits            42        43    +1
Impacted Files Coverage Δ
flake8_eradicate.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

wwuck commented 2 years ago

Rebased to fix merge conflicts