search

wemake-services / kira-dependencies

🐿 Kira's micro-bot to update project dependencies
https://dependabot.com
MIT License
103 stars 19 forks source link

Remove ruby version pinning #414

Closed b1rdex closed 1 year ago

b1rdex commented 1 year ago

I see no point in that pin – it's there just to break things when ruby version in the dependabot is bumped :D

FYI, that pin was removed from original dependabot-script repo a while ago: https://github.com/dependabot/dependabot-script/commit/afe3d78bddf48b86b761ad18c0207fc6d35c29e1

Recently, dependabot switched to ruby v3 (https://github.com/dependabot/dependabot-core/commit/2badf4b2c1584dd1155c3c223240750135c7c388) so I had to remove the pin to fix it.

b1rdex commented 1 year ago

Also, we use the latest version of Dependabot docker image by default: https://github.com/wemake-services/kira-dependencies/blob/a2597364dbdd0adc6740d35b34d9ed231e4f90c8/.gitlab-ci.yml#L19

I think we may then just unlock the dependency on omnibus to use the latest version too? https://github.com/wemake-services/kira-dependencies/blob/a2597364dbdd0adc6740d35b34d9ed231e4f90c8/Gemfile#L6

sobolevn commented 1 year ago

I think we may then just unlock the dependency on omnibus to use the latest version too?

Let's try it!