search

wemakecustom / gitlab-composer

Gitlab Composer repository
163 stars 44 forks source link

Add "dist" node into packages pointing to gitlab archive download #17

Closed Radio closed 7 years ago

Radio commented 8 years ago

Hello! This resolves the Issue #16.

lemoinem commented 8 years ago

Hey!

Thanks very much for the contribution... How do you account for the fact that some repo may be access restricted and would require authentication before downloading? Is this working seamlessly or do you need an auth.json?

If there are no good way to do this, I'm guessing we should make sure a package is public before adding a dist node.

Radio commented 8 years ago

Hi!

I agree, this PR is useful only with public repositories. Unfortunately I found no ways to get access to the package via the http for private repository. Only normal cookies work. auth.json works only for Basic Auth AFAIK.

lemoinem commented 8 years ago

Hi!

That's what I was afraid of...

Could you update the code so the dist node is only generated for public repositories? If we find a way to authenticate against GitLab in the future, we'll be able to add it in a BC way.