search

wemakecustom / gitlab-composer

Gitlab Composer repository
163 stars 44 forks source link

Set default timezone #2

Closed mishak87 closed 10 years ago

mishak87 commented 10 years ago

https://github.com/wemakecustom/gitlab-composer/blob/master/htdocs/packages.php#L125

lavoiesl commented 10 years ago

I am sorry, what are you requesting here ? The timezone should be taken from Gitlab and not from PHP ?

mishak87 commented 10 years ago

Code produces warning if it would be possible to use one from Gitlab that would be splendid! Since the date is produced by it. Or parse it without dependency on local timezone (in GMT).

I am really happy with this tool.

lavoiesl commented 10 years ago

GitLab’s time format is in GMT and filemtime returns a timestamp, which is also GMT, I don’t see the issue.

It seems that it is simply your PHP installation that isn’t properly configured. See http://ca1.php.net/manual/en/function.date-default-timezone-get.php

N.B.: Just to be clear, the default timezone doesn’t affect at all the behaviour of this tool, it is simply that strtotime WILL complain if a TZ is not set.