search

wemakecustom / gitlab-composer

Gitlab Composer repository
163 stars 44 forks source link

added ability to add in a static reference to a 3rd party lib #20

Closed pteague closed 8 years ago

pteague commented 8 years ago

I've needed to pull in 3rd party libraries as well so I don't have to manually list them in all of the composer.json files for different projects. I can change the static-repos.json sample to a different project if you want me to, just let me know.

lemoinem commented 8 years ago

Thank you very much for your contribution.

My point is, since the static repos potentially override the repos from GitLab, I imagine, someone will forget they have set such a repo and start wondering why the updates to their repo doesn't do anything for THIS repo. Having a flag specifying that the repo is from a static source and not from GitLab will instantly help recognize this issue.

Therefore, For debugging purposes, could you, automatically add an item in the packages' extras named _source, set to static, or something similar. Of course, make sure this doesn't override any extra already set by the package, please.

Once this is good, I'm ready to merge the feature in.

Thanks.

pteague commented 8 years ago

Did you want that in the sample static json file or programmatically added in?

lemoinem commented 8 years ago

No, I meant programmatically added in, it shouldn't be in the sample...

pteague commented 8 years ago

Ok, that should work. Only issue might be if some other project actually makes use of "_source" within the "extra" section, but I'm not currently aware of any.

lemoinem commented 8 years ago

thank you for putting on with all my requests :) Great Job, please, keep up the good work!

pteague commented 8 years ago

np & thanks for letting me & BigE contribute (I had to rewrite all our previous updates because of code changes before I realized we hadn't made a pull request, took so long to get permission). Last place I used this closed down, but I still use my own GitLab. Places I've been interviewing all use git, so might be introducing this again elsewhere.