The cache folder should be created automatically

wemakecustom / gitlab-composer

Gitlab Composer repository

163 stars 44 forks source link

The cache folder should be created automatically #22

Closed Jimbolino closed 7 years ago

lemoinem commented 7 years ago

Yes, it should be. However it would be better if it was created in the code and not hard coded in the git repository.

Having the folder hard coded in the GIT repository won't help you if the directory has been deleted (as a nuke-it-from-orbit solution to clear the cache, for example) and could create issues such as #23 ...

Jimbolino commented 7 years ago

How should the php script create folders? That would need a writable project root, which is way more insecure than a 777 cache folder...

lemoinem commented 7 years ago

Merged as per https://github.com/wemakecustom/gitlab-composer/pull/23#issuecomment-264737541

Thanks!