search

wemakecustom / gitlab-composer

Gitlab Composer repository
163 stars 44 forks source link

Not compatible with 9.10.0 of m4tthumphrey/php-gitlab-api #33

Closed gogowitsch closed 6 years ago

gogowitsch commented 6 years ago

Problem: Uncaught TypeError: Argument 1 passed to Gitlab\Client::__construct() must be an instance of Gitlab\HttpClient\Builder, string given around line 40 of packages.php.

Solution:

  1. composer require php-http/curl-client guzzlehttp/psr7 php-http/message
  2. change $client = new Client($confs['endpoint']); to $client = Client::create($confs['endpoint']);
  3. Around line 184, always call ->all instead of ->accessible, as the method has been removed.
gogowitsch commented 6 years ago

Nevermind, I just realized you already updated this code. All is good & /close

lemoinem commented 6 years ago

@Fonata Thanks for opening (and closing ;) ) an issue and Thanks for your continued use of gitlab-composer. As you may have notice, this project is receiving very limited support.

In particular, in the future, if you do know what code changes are necessary, I would encourage you to submit a PR instead of creating an issue.