wemixarchive / go-wemix

Go implementation of the Wemix project.
https://www.wemix.com/
GNU Lesser General Public License v3.0
29 stars 25 forks source link

Support compilaton with Go 1.23 #118

Closed yorickdowne closed 1 month ago

yorickdowne commented 3 months ago

Feature

Compilation with Go 1.23 currently fails. Compilation with Go 1.22 works.

171.8 github.com/ethereum/go-ethereum/cmd/gwemix
172.2 # github.com/ethereum/go-ethereum/cmd/gwemix
172.2 link: github.com/fjl/memsize: invalid reference to runtime.stopTheWorld
172.3 util.go:47: exit status 1
172.3 exit status 1
172.3 make: *** [Makefile:47: gwemix] Error 1
yorickdowne commented 3 months ago

Upstream: https://github.com/fjl/memsize/issues/5

yorickdowne commented 3 months ago

Go team rejected the memsize author’s proposal to make memsize work with Go 1.23.

Upstream go-ethereum fixed this by removing memsize in this patch: https://github.com/ethereum/go-ethereum/commit/e4675771eda550e7eeb63a8884816982c1980644