search

wendall911 / TCIntegrations

A Minecraft 1.18+ mod designed to provide modpack integrations with other mods for Tinkers' Construct
MIT License
3 stars 5 forks source link

Mod breaks Tinkers Construct's bronze recipe #29

Closed KnightMiner closed 2 years ago

KnightMiner commented 2 years ago

This mod currently adds its custom bronze recipe at the same path as Tinkers' recipe. This causes it to override the proper bronze recipe even when the pack includes tin, which has lead to a ton of users being confused and thinking Tinkers is to blame for having a broken recipe. Please create that recipe under your own namespace so it does not delete our recipe.

Really in general, remove all your custom recipes from our namespace. There is no reason your mod should be creating recipes under tconstruct unless they are an override, create new recipes under your mod ID. All our datagenerators support you choosing a mod ID to generate your recipes. Do not use our BaseRecipeProvider, make your own using your own ID, literally the only purpose of that class is to set the output mod ID

wendall911 commented 2 years ago

Ok, will fix this and push something out soon. Thanks for pointing this out.

wendall911 commented 2 years ago

I added a conditional for bronze to only show the alternate if zinc is missing. I also moved all recipes into the proper namespace.

wendall911 commented 2 years ago

@KnightMiner One side note. I actually only intended this mod to be for 1.18.1 temporarily to be able to address overriding diamond/emerald modifiers, as there was no datagen yet, and a recipe for bronze without tin. However, after getting a ton of requests, I eventually added a bunch more stuff. I never did go back and clean up the bronze implementation. Apologies for causing the issue.