wendall911 / TCIntegrations

A Minecraft 1.18+ mod designed to provide modpack integrations with other mods for Tinkers' Construct
MIT License
3 stars 5 forks source link

Make Soul Stained modifier do the cool thing #45

Closed SammySemicolon closed 1 year ago

SammySemicolon commented 1 year ago

!!! I have quite frankly no idea how I managed to load the game using lodestone 1.4.1 and TCIntegrations, given that the directory of LodestoneAttributeRegistry has changed but whatever !!!

SammySemicolon commented 1 year ago

Ok so this is rlly confusing my IDE seems to have still been using 1.3.0 lodestone while writing the commit which means the game now crashes anytime u hold a soul-stained tool once again. Let me try and fix that?

SammySemicolon commented 1 year ago

OKay nvm it was correctly using Lodestone 1.4.1, but for 1.19.2 rather than 1.18.2 sobbing

SammySemicolon commented 1 year ago

I fixed it up, and tested in game. Works fine :)

SammySemicolon commented 1 year ago

As a sidenote, including the magic damage amount in the tooltip of the weapon, alongside regular damage, would be appreciated.

wendall911 commented 1 year ago

Awesome, thanks! I'll work on this tomorrow and get a new release out. I'll add the magic damage to the tooltip as well.